-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Revert "Add libblkid / liblzma / libgcrypt to Linux requirements" #5504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for reverting this. I am not familiar with snapd and Linux tooling. As it's in draft mode, I won't otherwise comment on it right now.
Yeah, let's wait to see if this gets approved before making changes to the docs. Thanks! |
|
SG |
|
@sfshaza2 this can merge now. Thanks! |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
We should probably temporarily revert this change; I didn't think about it at the time, but many users are now using desktop in the beta and stable channels, where the other libraries are still necessary. I've seen a few issues come in where prior followed these instructions, but then we're missing libraries, because they were in stable. This should be changed only once the Flutter changes that go with it reach stable. |
The only library that legitimately should be on this list is I've reverted this here and here. The others ( Sorry for all the back and forth on this! |
Well, now that 2.2 has shipped my comment is moot.
This statement is not correct, which is why the instructions should not actually have been changed while 2.0 was the stable release. The motivation to add them was for snap usage, but they were made requirements in every single developer's app templates regardless of whether they were using the snap or not. Which means that not having them installed prevented compilation. |
|
Yes, they were made requirements. This is what I was referring to when I said they “should never have been added”. As in, they should never have been added to the CMake, nor the docs. |
Following on from this conversation:
Please accept my sincerest apologies for this! The last few updates to
desktop.mdare actually only required for the snap package and thus should not have been made upstream. This PR reverts those changes.See also: flutter/flutter#78415