Skip to content

Conversation

@MarcusTomlinson
Copy link
Contributor

@MarcusTomlinson MarcusTomlinson commented Mar 17, 2021

Following on from this conversation:

Please accept my sincerest apologies for this! The last few updates to desktop.md are actually only required for the snap package and thus should not have been made upstream. This PR reverts those changes.

See also: flutter/flutter#78415

@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Mar 17, 2021
@MarcusTomlinson MarcusTomlinson changed the title Revert "Add libgcrypt to Linux requirements" Revert "Add libblkid / liblzma / libgcrypt to Linux requirements" Mar 17, 2021
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for reverting this. I am not familiar with snapd and Linux tooling. As it's in draft mode, I won't otherwise comment on it right now.

@MarcusTomlinson
Copy link
Contributor Author

Ah, thanks for reverting this. I am not familiar with snapd and Linux tooling. As it's in draft mode, I won't otherwise comment on it right now.

Yeah, let's wait to see if this gets approved before making changes to the docs. Thanks!

@sfshaza2
Copy link
Contributor

SG

@MarcusTomlinson MarcusTomlinson marked this pull request as ready for review March 18, 2021 16:23
@MarcusTomlinson
Copy link
Contributor Author

MarcusTomlinson commented Mar 18, 2021

@sfshaza2 this can merge now. Thanks!

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2 sfshaza2 merged commit b4c7adb into flutter:master Mar 18, 2021
@stuartmorgan-g
Copy link
Contributor

We should probably temporarily revert this change; I didn't think about it at the time, but many users are now using desktop in the beta and stable channels, where the other libraries are still necessary. I've seen a few issues come in where prior followed these instructions, but then we're missing libraries, because they were in stable.

This should be changed only once the Flutter changes that go with it reach stable.

@MarcusTomlinson
Copy link
Contributor Author

MarcusTomlinson commented Jun 16, 2021

We should probably temporarily revert this change

The only library that legitimately should be on this list is liblzma (indefinitely - not temporarily). This is because some distros (such as Fedora 33+ & Ubuntu 20.04+) have since removed liblzma from their default installed packages.

I've reverted this here and here.

The others (libblkid & libgcrypt) should never have been added upstream as those only ever showed up in snap usage.

Sorry for all the back and forth on this!

@stuartmorgan-g
Copy link
Contributor

We should probably temporarily revert this change

The only library that legitimately should be on this list is liblzma

Well, now that 2.2 has shipped my comment is moot.

The others (libblkid & libgcrypt) should never have been added upstream as those only ever showed up in snap usage.

This statement is not correct, which is why the instructions should not actually have been changed while 2.0 was the stable release. The motivation to add them was for snap usage, but they were made requirements in every single developer's app templates regardless of whether they were using the snap or not. Which means that not having them installed prevented compilation.

@MarcusTomlinson
Copy link
Contributor Author

MarcusTomlinson commented Jun 16, 2021

Yes, they were made requirements. This is what I was referring to when I said they “should never have been added”. As in, they should never have been added to the CMake, nor the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants