Repository navigation
Adding eliminating-null-parameters migration guide - #4921
Merged
gspencergoog merged 4 commits intoJan 28, 2021
Merged
Conversation
google-cla
Bot
added
the
cla: yes
This was referenced Oct 28, 2020
Merged
Remove nullOk parameter from Router.of and make it return a non-nullable value
flutter/flutter#68910
Merged
gspencergoog
force-pushed
the
eliminating-nullok-parameters
branch
2 times, most recently
from
November 17, 2020 23:22
1e1fcd4 to
e7c76d4
Compare
gspencergoog
force-pushed
the
eliminating-nullok-parameters
branch
from
January 21, 2021 00:47
e7c76d4 to
8451ca4
Compare
This was referenced Jan 25, 2021
gspencergoog
force-pushed
the
eliminating-nullok-parameters
branch
from
January 26, 2021 01:30
8451ca4 to
017557a
Compare
gspencergoog
marked this pull request as ready for review
January 26, 2021 01:30
gspencergoog
changed the title
goderbauer
approved these changes
Jan 26, 2021
Piinks
requested changes
Jan 28, 2021
Piinks
reviewed
Jan 28, 2021
Piinks
reviewed
Jan 28, 2021
Piinks
reviewed
Jan 28, 2021
Piinks
reviewed
Jan 28, 2021
Contributor
There was a problem hiding this comment.
To sum up, these methods appear to be missing:
CupertinoThemeData.maybeResolveFromNoDefaultCupertinoThemeData.maybeResolveFromCupertinoTextThemeData.maybeResolveFromMaterialBasedCupertinoThemeData.maybeResolveFrom
Updated after audit:
CupertinoDynamicColor.maybeResolveFrom
8 tasks done
Piinks
reviewed
Jan 28, 2021
Piinks
reviewed
Jan 28, 2021
Contributor
|
Sorry for flooding your inbox, I think I understand that the 'missing' methods may not be missing, but instead are listed here by mistake. The PR description in flutter/flutter#68905 mentions not needing the maybeOf for all of them |
gspencergoog
commented
Jan 28, 2021
gspencergoog
left a comment
gspencergoog
left a comment
Contributor
Author
There was a problem hiding this comment.
OMG. Thanks: I wrote this when we started, and a bunch of things changed along the way, I guess. I think we decided that all the resolveFrom routines should never return null anyhow, and just eliminated the maybeResolveFrom versions. Anyhow, thanks for going through those.
Piinks
approved these changes
Jan 28, 2021
filiph
pushed a commit
to filiph/website
that referenced
this pull request
Feb 22, 2021
Adding a migration guide for eliminating null parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a migration guide for eliminating null parameters.