Skip to content

Conversation

@ycv005
Copy link
Contributor

@ycv005 ycv005 commented Oct 17, 2020

Added a Recommended Version because new Flutter stable version- 1.22.2 contains important fixes related to the Hybrid composition.

For More detail see- flutter/engine#21841

Fixes

Changes proposed in this pull request:

  • Added a recommended version so that user won't get major issues related to Hybrid compositon.
  • This avoid recreation of the issue as well as save time for developers.

Added a Recommended Version because new Flutter stable version- 1.22.2 contains important fixes related to the Hybrid composition. For More detail see- flutter/engine#21841
@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Oct 17, 2020
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @ycv005! With a little change, I can merge it.

features might not work.

* Hybrid composition requires Flutter 1.22. This mode appends the
* Hybrid composition requires Flutter 1.22 (recommended version- 1.22.2). This mode appends the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link "version 1.22.2" to the GitHub wiki: https://github.com/flutter/flutter/wiki/Hotfixes-to-the-Stable-Channel#1222--october-16-2020
Also, remove the hyphen "-".

So, the change should look like the following:

* Hybrid composition requires Flutter 1.22 ([version 1.22.2][] is recommended). 
  This mode appends the

[version 1.222]: {{site.github}}/flutter/flutter/wiki/Hotfixes-to-the-Stable-Channel#1222--october-16-2020

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya Sure.

Copy link
Contributor Author

@ycv005 ycv005 Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sfshaza I have made changes as said. Have a look & let me know, if anything else needed or not.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2 sfshaza2 merged commit 9e50636 into flutter:master Oct 19, 2020
filiph pushed a commit to filiph/website that referenced this pull request Feb 22, 2021
* Added a Recommended Version of the Flutter

Added a Recommended Version because new Flutter stable version- 1.22.2 contains important fixes related to the Hybrid composition. For More detail see- flutter/engine#21841

* fix format, add link
ribandgel pushed a commit to ribandgel/flutter_inappwebview that referenced this pull request Jun 28, 2025
Hybrid composition works well when the Flutter version is above 1.22.2. Here is more detail- flutter/website#4890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants