-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Added a Recommended Version of the Flutter #4890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a Recommended Version because new Flutter stable version- 1.22.2 contains important fixes related to the Hybrid composition. For More detail see- flutter/engine#21841
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, @ycv005! With a little change, I can merge it.
| features might not work. | ||
|
|
||
| * Hybrid composition requires Flutter 1.22. This mode appends the | ||
| * Hybrid composition requires Flutter 1.22 (recommended version- 1.22.2). This mode appends the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you link "version 1.22.2" to the GitHub wiki: https://github.com/flutter/flutter/wiki/Hotfixes-to-the-Stable-Channel#1222--october-16-2020
Also, remove the hyphen "-".
So, the change should look like the following:
* Hybrid composition requires Flutter 1.22 ([version 1.22.2][] is recommended).
This mode appends the
[version 1.222]: {{site.github}}/flutter/flutter/wiki/Hotfixes-to-the-Stable-Channel#1222--october-16-2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sfshaza I have made changes as said. Have a look & let me know, if anything else needed or not.
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Added a Recommended Version of the Flutter Added a Recommended Version because new Flutter stable version- 1.22.2 contains important fixes related to the Hybrid composition. For More detail see- flutter/engine#21841 * fix format, add link
Hybrid composition works well when the Flutter version is above 1.22.2. Here is more detail- flutter/website#4890
Added a Recommended Version because new Flutter stable version- 1.22.2 contains important fixes related to the Hybrid composition.
For More detail see- flutter/engine#21841
Fixes
Changes proposed in this pull request: