Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 30, 2020

This migration means users can remove workaround introduced in flutter/flutter#20685 (comment), which will improve compilation time.

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Apr 30, 2020
@jmagman jmagman requested a review from sfshaza2 April 30, 2020 21:35
@jmagman
Copy link
Member Author

jmagman commented Apr 30, 2020

@sfshaza2 Should I mention flutter/flutter#20685 anywhere? That's the issue where that workaround was introduced, but now we don't need that workaround with these documented migration steps. But I don't want to confuse anyone.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants