Repository navigation
Add migration guide for WidgetSpan ordering in RTL text - #13988
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation for a breaking change where WidgetSpans in right-to-left (RTL) and mixed-direction text now follow the bidirectional visual order determined by the Unicode bidirectional algorithm. It introduces a new markdown file detailing the background, migration steps (such as removing coordinate mirroring or manual translation workarounds), and timeline, and registers this new document in the breaking changes index. I have no feedback to provide as the changes are complete and well-written.
conooi
left a comment
conooi
left a comment
There was a problem hiding this comment.
@meg4cyberc4t Thanks for fixing this issue and contributing the migration guide! I left a few small suggestions for clarity, style, and converting the screenshots to WebP format.
Document the corrected visual order of WidgetSpans in RTL and mixed-direction text, including how to remove compensating workarounds. Add before-and-after screenshots and an entry in the unreleased breaking change index. Related to flutter/flutter#54400.
Co-authored-by: Connie Ooi <[email protected]>
60bd84a to
6000378
Compare
|
@conooi Hi! Thanks for the help! |
|
/gcbrun |
|
Staged preview of the updated docs.flutter.dev site (updated for commit 2a75fc5): |
|
/gcbrun |
conooi
left a comment
conooi
left a comment
There was a problem hiding this comment.
@meg4cyberc4t Thanks for your contribution! LGTM
Documents the corrected WidgetSpan order in RTL and mixed-direction text.
Apps that compensated for the old source-order layout can now position
widgets incorrectly; the guide explains which workarounds to remove.
Includes before-and-after screenshots and an entry under
"Not yet released to stable". The fix landed in Flutter 3.50.0-0.1.pre.
Related issue: flutter/flutter#54400
Related change: https://skia-review.googlesource.com/c/skia/+/1366676
The fix has already landed.