Skip to content

Updating the animations pages and corresponding examples - #13944

Merged
sfshaza2 merged 14 commits into
mainfrom
refresh-animations-tutorial
Oct 2, 2026
Merged

sfshaza2 merged 14 commits into
mainfrom
refresh-animations-tutorial

Conversation

@sfshaza2

Copy link
Copy Markdown
Contributor

The Dashboard listed the /ui/animations/tutorial page as being particularly stale.

This PR's updates include:

  • Updating the text, patterns described, etc for all of the files in /ui/animations.
  • Updating the example code
  • Adding code excerpts to the pages (the animations work predates code-excerpts).
  • Removing the /examples/_animations directory, which wasn't being used on the site.

@sfshaza2
sfshaza2 requested a review from a team as a code owner September 30, 2026 20:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the animation examples by moving them from _animation to animation/ and updates the documentation to use code excerpts. However, it incorrectly replaces the standard package:flutter/material.dart imports and dependencies with a third-party material_ui package across multiple example apps, tests, and pubspec files. Additionally, several standard Flutter framework class links in the documentation were incorrectly changed to point to this third-party package on pub.dev. These changes must be reverted to use standard Flutter APIs and official documentation links.

@flutter-website-bot

flutter-website-bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

@parlough parlough self-assigned this Oct 1, 2026
@parlough

parlough commented Oct 1, 2026

Copy link
Copy Markdown
Member

/gemini review

gemini-code-assist[bot]

This comment was marked as resolved.

@flutter-website-bot

Copy link
Copy Markdown
Collaborator

vsync: this,
);
// #enddocregion animation-controller, tweens
animation = CurvedAnimation(parent: controller, curve: Curves.easeIn)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't disposed, might leak.

@hannah-hyj hannah-hyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lamek lamek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2
sfshaza2 merged commit aa7d961 into main Oct 2, 2026
16 checks passed
@sfshaza2
sfshaza2 deleted the refresh-animations-tutorial branch October 2, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants