Skip to content

Decoupling Material and Cupertino from the core framework - #13930

Merged
sfshaza2 merged 13 commits into
mainfrom
decouping
Sep 29, 2026
Merged

sfshaza2 merged 13 commits into
mainfrom
decouping

Conversation

@sfshaza2

@sfshaza2 sfshaza2 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

This PR is ready for review. There are too many changes to list each page or each example, but here are some of the highlights:

Other than the embedded DartPad examples, I haven't paid attention to the localization pages yet. I'd like to land this and then incrementally fix other things that need addressing. The rest of the writing team is trying not to step on my toes for this PR, so I'd like to get it approved and landed.

THANKS!

@sfshaza2
sfshaza2 requested a review from a team as a code owner September 25, 2026 20:18
@parlough
parlough self-requested a review September 25, 2026 20:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates package imports across numerous example files, replacing 'package:flutter/material.dart' and 'package:flutter/cupertino.dart' with 'package:material_ui/material.dart' and 'package:cupertino_ui/cupertino.dart' respectively. The review feedback correctly identifies a few files that inconsistently import 'package:cupertino_dart/cupertino.dart' instead of 'package:cupertino_ui/cupertino.dart', which could lead to compilation errors.

@flutter-website-bot

flutter-website-bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

@sfshaza2

Copy link
Copy Markdown
Contributor Author

/gcbrun

@sfshaza2
sfshaza2 requested review from Piinks and justinmc September 29, 2026 01:04
Comment thread sites/docs/src/content/ui/index.md Resolved
Piinks

This comment was marked as resolved.

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments and questions 👍 Confirmed that you have the latest versions of each package. I have not checked the URLs that @Piinks mentioned above.

Comment thread sites/docs/src/content/ui/index.md Resolved
Comment thread sites/docs/src/content/ui/index.md Resolved
Comment thread sites/docs/src/content/ui/index.md Resolved
@sfshaza2

Copy link
Copy Markdown
Contributor Author

Are the changes to old breaking change guides and old release notes intended? Some of the links may not resolve if they are referring to something that does not exist anymore.

Some of those are intentional. Our build process breaks once links are no longer valid, which is coming. The alternative is to just remove the links entirely and leave the text. Do you prefer that?

@sfshaza2
sfshaza2 merged commit b11d153 into main Sep 29, 2026
16 checks passed
@sfshaza2
sfshaza2 deleted the decouping branch September 29, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants