Repository navigation
Add breaking change page for DropdownButton enabled property - #13430
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request documents a breaking change introducing the enabled property and making the onChanged callback optional for DropdownButton and DropdownButtonFormField. The feedback focuses on improving the documentation quality by adhering to style guidelines (avoiding first-person pronouns and abbreviations like 'i.e.'), wrapping lines to respect an 80-character limit, and ensuring consistent link text that matches the page title.
…-enabled-property.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…-enabled-property.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…-enabled-property.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…-enabled-property.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…optional enabled property and onChanged callback
|
@justinmc, can you either review or delegate? |
|
/gcbrun |
|
Staged preview of the updated docs.flutter.dev site (updated for commit 59d3276): |
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Thanks for your hard work on this feature @Mairramer!
|
Thanks for your review, @justinmc! @Mairramer, can you address Justin's final nits so I can land? Thx! |
|
I’ve now formatted it using the |
|
/gcbrun |
Description of what this PR is changing or adding, and why:
Adds a breaking change page for the new
enabledproperty logic onDropdownButtonandDropdownButtonFormField. This explains why theonChangedcallback is no longer required and clarifies the fallback behavior for backward compatibility. It also guides developers on how to properly separate interactive state (enabled) from widget behavior (onChanged), highlighting what thedart fixcovers and what requires manual migration (like conditional logic).Issues fixed by this PR (if any):
N/A but related to flutter/flutter#57953
PRs or commits this PR depends on (if any):
Depends on flutter/flutter#182419
Presubmit checklist
of 80 characters or fewer.