Skip to content

Conversation

@craiglabenz
Copy link
Contributor

@craiglabenz craiglabenz commented Oct 30, 2024

Description of what this PR is changing or adding, and why:

Improves and adds documentation for launching Flutter from Kotlin and Compose-flavored Android apps

Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Depends on flutter/flutter#156502. Must either use the master channel or stable after that code reaches it.

Changes can be previewed on the staging built at these URLs:

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@craiglabenz craiglabenz requested review from a team, parlough and sfshaza2 as code owners October 30, 2024 19:13
@craiglabenz
Copy link
Contributor Author

cc @gmackall

@gmackall
Copy link
Member

Cherry pick request at flutter/flutter#157881, will update here if it gets accepted

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Oct 31, 2024

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @craiglabenz! lgtm

@sfshaza2 sfshaza2 merged commit ab2ea7b into main Oct 31, 2024
9 checks passed
@sfshaza2 sfshaza2 deleted the launch-flutter-from-compose branch October 31, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants