Skip to content

Re-enable flutter_devtools.test and flutter_devtools_analysis.test #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bkonyi merged 4 commits into from
Jan 15, 2025
Merged

Re-enable flutter_devtools.test and flutter_devtools_analysis.test #440

bkonyi merged 4 commits into from
Jan 15, 2025

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Jan 15, 2025

@bkonyi bkonyi requested a review from kenzieschmoll January 15, 2025 16:42
@bkonyi bkonyi changed the title Reenable flutter_devtools.test and flutter_devtools_analysis.test Re-enable flutter_devtools.test and flutter_devtools_analysis.test Jan 15, 2025
@kenzieschmoll
Copy link
Member

kenzieschmoll commented Jan 15, 2025

does the devtools hash need to be updated to a newer version for this change to land?

@bkonyi
Copy link
Contributor Author

bkonyi commented Jan 15, 2025

does the devtools hash need to be updated to a newer version for this change to land?

The hash in the SDK?

@kenzieschmoll
Copy link
Member

kenzieschmoll commented Jan 15, 2025

No the devtools commit hash in the flutter_devtools.test and flutter_devtools_analysis.test files

@bkonyi
Copy link
Contributor Author

bkonyi commented Jan 15, 2025

No the devtools commit hash in the flutter_devtools.test and flutter_devtools_analysis.test files

Oh, I had no idea there was hashes in these files. Done.

@bkonyi bkonyi merged commit 88480e2 into main Jan 15, 2025
12 checks passed
@bkonyi bkonyi deleted the reenable_devtools_tests branch January 15, 2025 19:17
@zanderso zanderso mentioned this pull request Jan 16, 2025
Merged
jonahwilliams pushed a commit that referenced this pull request Jan 16, 2025
@zanderso
Revert "Re-enable flutter_devtools.test and flutter_devtools_analysis…
df70b53 
….test" (#442)

Reverts #440

Failing as in
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20customer_testing/22257/overview
victoreronmosele pushed a commit to victoreronmosele/tests that referenced this pull request Feb 5, 2025
@bkonyi @victoreronmosele
Re-enable flutter_devtools.test and flutter_devtools_analysis.test (f…
be84928 
…lutter#440)

Fixes flutter/flutter#160247
victoreronmosele pushed a commit to victoreronmosele/tests that referenced this pull request Feb 5, 2025
@zanderso @victoreronmosele
Revert "Re-enable flutter_devtools.test and flutter_devtools_analysis…
13f6ff0 
….test" (flutter#442)

Reverts flutter#440

Failing as in
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20customer_testing/22257/overview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-enable DevTools customer testing

2 participants

@bkonyi @kenzieschmoll