Exclude arm64 from simulator iOS add-to-app host app archs #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Jan 12, 2021
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "set -e\nset -u\nsource \"${SRCROOT}/../flutter_module/.ios/Flutter/flutter_export_environment.sh\"\n\"$FLUTTER_ROOT\"/packages/flutter_tools/bin/xcode_backend.sh build"; | ||
| shellScript = "set -e\nset -u\nsource \"${SRCROOT}/../flutter_module/.ios/Flutter/flutter_export_environment.sh\"\nexport VERBOSE_SCRIPT_LOGGING=1 && \"$FLUTTER_ROOT\"/packages/flutter_tools/bin/xcode_backend.sh build"; |
Comment on lines
-329
to
-334
| inputPaths = ( | ||
| "${SRCROOT}/../flutter_module/.metadata", | ||
| "${SRCROOT}/../flutter_module/.ios/Flutter/App.framework/App", | ||
| "${SRCROOT}/../flutter_module/.ios/Flutter/engine/Flutter.framework/Flutter", | ||
| "${SRCROOT}/../flutter_module/.ios/Flutter/flutter_export_environment.sh", | ||
| ); |
Member
Author
There was a problem hiding this comment.
Automatically removed by flutter/flutter#69846
This was referenced Jan 12, 2021
xster
approved these changes
Jan 12, 2021
This was referenced Aug 23, 2021
jmagman
added a commit
that referenced
this pull request
Aug 27, 2021
)" This reverts commit cf3857f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow iOS add-to-app host apps to run on Apple Silicon devices by explicitly excluding arm64 from the valid archs to run.
All add-to-app hosts will need to do this until flutter/flutter#64502 and friends are complete.
Website documentation: flutter/website#5174