Use xcframeworks in prebuilt add-to-app sample #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
xster
approved these changes
Nov 5, 2020
|
|
||
| # For iOS builds: | ||
| flutter build ios-framework --output=../ios_using_prebuilt_module/Flutter | ||
| flutter build ios-framework --xcframework --output=../ios_using_prebuilt_module/Flutter |
Member
There was a problem hiding this comment.
Since we're targeting stable here, I assume everything still works corretly on stable?
Member
Author
There was a problem hiding this comment.
Yup --xcframework is on stable. With this change it outputs the universal .frameworks on stable but it's just not consumed by the host app. On master it doesn't output the universal frameworks.
Member
Author
There was a problem hiding this comment.
And it worked against stable in the CI task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update add-to-app sample to use XCFrameworks instead of universal frameworks.
Universal (fat) frameworks that support physical devices and simulators aren't possible in an ARM simulator world since the arm64
iphoneosandiphonesimulatorslices can't belipod together in the same binary. Prefer--xcframeworkin expectation of that switch.See flutter/flutter#69718, flutter/flutter#69733, and overall macOS ARM support at flutter/flutter#60118