Remove Expanded from NavigationRail #2157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NavigationRail now uses a SingleChildScrollView (flutter/flutter#137415) fixes flutter/flutter#143061
kevmoo
approved these changes
Feb 7, 2024
Contributor
Author
|
Looks like I broke some tests, investigating... |
Member
|
If the framework change that caused this turns out to be too breaking we may just want to roll it back. Side node: should we run the samples tests as part of the framework presubmit to get an additional signal for breaking changes? The tests could be added to https://github.com/flutter/tests to accomplish that. |
Contributor
Author
|
This is turning out to be more difficult than I was expecting. The sidebar seems to be too large in the medium-width case:
|
Contributor
Author
|
Reverting flutter/flutter#137415 and adding this sample to our framework tests sounds good to me (although we might want to think about how to do that in a maintainable way) |
Member
|
I'll get the revert going... |
This was referenced Feb 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 7, 2024
Reverts #137415 Reverting due to #143061. this is breaking some existing use cases, see also flutter/samples#2157. If we try this again, we need to add this in less breaking way. Fixes #143061
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#137415 changed NavigationRail to use a SingleChildScrollView, so this sample can't use
Expandedfor thetrailingwidget anymore.cc: @goderbauer @QuncCccccc
Fixes flutter/flutter#143061