Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 14, 2022

Add-to-app host Podfiles will be required to call flutter_post_install(installer) when flutter/flutter#101943 merges. The addition of defined?(flutter_post_install) will allow pod install to succeed on versions of Flutter that do not yet have flutter_post_install available.

Hold until flutter/flutter#101943 merges.

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@jmagman jmagman self-assigned this Apr 14, 2022
@jmagman jmagman marked this pull request as ready for review April 15, 2022 01:42
Copy link

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Apr 15, 2022

@redbrogdon are these tests always broken? The beta macOS one looks like it's running on an M1 Mac but doesn't have Rosetta installed (which Flutter needs).

@domesticmouse
Copy link
Contributor

@redbrogdon are these tests always broken? The beta macOS one looks like it's running on an M1 Mac but doesn't have Rosetta installed (which Flutter needs).

The beta tests have been broken for a couple of weeks. I need to elide from beta CI a couple of projects that have lint warnings (that are turned into build errors by the CI scripts).

Regarding Rosetta, any ideas on what I need to do in GitHub action land to install Rosetta?

@domesticmouse domesticmouse merged commit c6bee7a into flutter:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants