This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Add currentUrl accessor to WebView plugin. #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efortuna
commented
Dec 19, 2018
amirh
reviewed
Dec 19, 2018
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
Thanks Emily! Overall looks good, left a few comments.
Contributor
|
We also need to make the bots happy 😄 |
efortuna
commented
Dec 19, 2018
Contributor
Author
efortuna
left a comment
efortuna
left a comment
There was a problem hiding this comment.
Thanks, Amir! Comments addressed. PTAL.
amirh
approved these changes
Dec 19, 2018
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
Thanks!
LGTM after addressing one last documentation nit.
I like the unit tests improvement!
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
* Add currentUrl accessor to WebView plugin.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit 631400e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Flutter to query to WebView to find out what URL it is currently displaying.