[google_maps_flutter_web] Initial support for custom overlays. #6982
Conversation
Saves tile bytes to blobs and uses `img` elements to decode and render. Does not implement opacity, perform caching, or serve placeholder images.
Clears the tile cache for an overlay by re-setting the overlay in the map `MVCArray`.
TODO: related controller/plugin tests
No change in functionality or generated mocks; more concise.
Capture arguments to verified mock calls directly rather than using capture + expect. This also collapses the 'empty infoWindow does not create InfoWindow instance.' test into the previous test + a test of `google_maps_flutter_platform_interface`, so it can be removed without loss of coverage or functional specificity.
GoogleMapsController tests for tile overlays
GoogleMapsPlugin tests for tile overlays
Minor version bump for custom tile overlays.
Lock to 2013, and add omissions.
Add comment for new test image resource, and correct an adjacent typo.
This rule was removed, and this usage should be safe.
AsturaPhoenix
force-pushed
the
overlay
branch
from
0270a45 to
de56233
Compare
|
For some reason this seems to be non-transiently timing out https://cirrus-ci.com/task/4717210967474176 |
|
Locally when I try to run against flutter 2.10.5, I get Which isn't the kind of hang we're seeing on CI. Not sure about next steps. |
|
Oh, I think I get it. This is its way of telling me to bump something in Or maybe I'll see if I can relax the |
Updates pubspec.yaml environment version constraints to reflect dependency requirements: * Dart 2.17.0 for mockito * Flutter 3.0.0 for collection (upgraded in 2.13.0-..., but those don't seem to be releases)
We need to go back to the future. After upgrading environment constraints, the analyzer picks up cases where we should use super parameters.
| img.src = src; | ||
| await img.decode(); | ||
| img.hidden = false; | ||
| Url.revokeObjectUrl(src); |
There was a problem hiding this comment.
We might want to put this in a finally. On the other hand, not revoking the blob URL in the case of a decoding failure may actually make debugging easier.
|
Per discussion offline with @ditman, google_maps_flutter reviews have been on hold for now due to high-priority work on another plugin, but will be next on the queue. Thanks for being patient on the review here! |
| expect(capturedPolylines.first.polylineId.value, 'polyline-1'); | ||
| }); | ||
|
|
||
| testWidgets('empty infoWindow does not create InfoWindow instance.', |
There was a problem hiding this comment.
Leaving a comment here because it wasn't obvious to me the second time I looked at it:
This test was removed because it became trivial once using Mockito verification; it essentially tests to make sure that Marker.infoWindow defaults to InfoWindow.noText. On the other hand, the argument could be made to keep it anyway (e.g. to construct the verification with an explicit infoWindow: InfoWindow.noText); let me know if you'd prefer that.
|
We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages. Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord. Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state! |
2 participants
Saves tile bytes to blobs and uses
imgelements to decode and render. Does not implement opacity, perform caching, or serve placeholder images.Issue: flutter/flutter#98596
Known issues:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.