Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[file_selector] Endorse Linux implementation #6293

Merged
auto-submit merged 8 commits into from
Aug 19, 2022
Merged

[file_selector] Endorse Linux implementation #6293

auto-submit merged 8 commits into from
Aug 19, 2022

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Aug 18, 2022

Endorses file_selector_linux now that it's part of flutter/plugins.

Fixes flutter/flutter#70221

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 18, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Aug 18, 2022

The first commit is just flutter create --platforms linux with no changes; everything I changed is in the following commits.

@Hixie
Copy link
Contributor

Hixie commented Aug 18, 2022

test-exempt: configuration change that enables tests

cbracken
cbracken approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 19, 2022
@auto-submit auto-submit bot merged commit c9403f1 into flutter:main Aug 19, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2022
@engine-flutter-autoroll
c9403f1cf [file_selector] Endorse Linux implementation (flutter/plugi…
d4913cc 
…ns#6293)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2022
@engine-flutter-autoroll
c9403f1cf [file_selector] Endorse Linux implementation (flutter/plugi…
0a340a8 
…ns#6293)
tarrinneal pushed a commit to tarrinneal/plugins that referenced this pull request Aug 19, 2022
@stuartmorgan-g @tarrinneal
[file_selector] Endorse Linux implementation (flutter#6293)
82b97ff
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
@stuartmorgan-g @moisefeelin
[file_selector] Endorse Linux implementation (flutter#6293)
aa5922b
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@stuartmorgan-g @mauricioluz
[file_selector] Endorse Linux implementation (flutter#6293)
0e41994
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests p: file_selector platform-linux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[file_selector] Add desktop implementations

3 participants

@stuartmorgan-g @Hixie @cbracken