This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[file_selector] Import Linux implementation from FDE #6292
Merged
auto-submit
merged 9 commits into
flutter:main
from
stuartmorgan-g:file-selector-linux-import
Aug 18, 2022
Merged
[file_selector] Import Linux implementation from FDE #6292
auto-submit
merged 9 commits into
flutter:main
from
stuartmorgan-g:file-selector-linux-import
Aug 18, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The first commit has zero changes from the already-reviewed FDE implementation, so you only need to review the deltas from that (unless you want to fully re-review the plugin). Let me know if you want me to split out the non-Linux bits. They seemed minor enough to toss in, but I could easily make a new PR. |
cbracken
approved these changes
Aug 18, 2022
Member
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2022
tarrinneal
pushed a commit
to tarrinneal/plugins
that referenced
this pull request
Aug 19, 2022
moisefeelin
pushed a commit
to feelinproject/plugins
that referenced
this pull request
Aug 26, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
p: file_selector
platform-linux
platform-macos
platform-windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Imports the existing Linux implementation from the flutter-desktop-embedding repository, with very minor changes for the move:
Adds
xvfbto Linux unit tests, since the file_selector test requires GTK initialization that fails without a display server.This also opportunistically makes some minor non-code cleanups to the Windows and macOS implementations, noticed while I was making sure everything was consistent:
flutter_testtodev_dependencies, rather than accidentally being independencies. (In practice, not a big deal since it's from the SDK, but there's no reason for it to be in the non-dev section.)Part of flutter/flutter#70221
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).