This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Add use_named_constants to analysis options and fix errors #6281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
requested review from
GaryQian,
camsim99,
cyanglaz,
ditman,
gaaclarke,
hellohuanlin and
stuartmorgan-g
as code owners
stuartmorgan-g
suggested changes
Aug 17, 2022
packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Contributor
|
Overriding the version change flag for |
stuartmorgan-g
added
the
override: no versioning needed
stuartmorgan-g
approved these changes
Aug 17, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM once it's merged to fix analyze
tarrinneal
deleted the
add-use_named_constants-to-analysis-options-and-fix-errors
branch
|
|
||
| ## 2.1.11 | ||
|
|
||
| * Fixes violations of new analysis option use_named_constants. |
Contributor
There was a problem hiding this comment.
This got merged incorrectly; you added this to the release notes of an already-released version, and didn't add a new version update to release the changed production code. (Normally CI would have caught this, but the override we added for video_player masked it).
Could you do a follow-up to move this line to a new 2.1.12?
Contributor
Author
There was a problem hiding this comment.
I'll send that up shortly
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2022
moisefeelin
pushed a commit
to feelinproject/plugins
that referenced
this pull request
Aug 26, 2022
) * update to remove errors related to analysis option * update to remove errors related to analysis option * remove errors related to analysis option * remove errors related to analysis option * remove errors related to analysis option * remove errors related to analysis option * add use_named_constants * Fix violations of analysis opt use_named_constants * revert metada changes * Updated changelogs to correct version nums * undo automated changes * Reconsile changes by bots that cause failing tests
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
) * update to remove errors related to analysis option * update to remove errors related to analysis option * remove errors related to analysis option * remove errors related to analysis option * remove errors related to analysis option * remove errors related to analysis option * add use_named_constants * Fix violations of analysis opt use_named_constants * revert metada changes * Updated changelogs to correct version nums * undo automated changes * Reconsile changes by bots that cause failing tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the use_named_constants line to analysis options and fixed all new violation errors.
List which issues are fixed by this PR. You must list at least one issue.
Some fixes for #96229
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.