This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter_platform_interface] Adds missing build params for WebViewWidget #6279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
p: webview_flutter
bparrishMines
changed the title
stuartmorgan-g
approved these changes
Aug 18, 2022
| /// [ListView] will want to handle vertical drags. The web view will claim | ||
| /// gestures that are recognized by any of the recognizers on this list. | ||
| /// | ||
| /// When this is empty or null, the web view will only handle pointer events |
Contributor
There was a problem hiding this comment.
We should make this non-nullable with empty default so there aren't two ways of expressing the same thing.
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2022
…ams for WebViewWidget (flutter/plugins#6279)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2022
…ams for WebViewWidget (flutter/plugins#6279)
tarrinneal
pushed a commit
to tarrinneal/plugins
that referenced
this pull request
Aug 19, 2022
moisefeelin
pushed a commit
to feelinproject/plugins
that referenced
this pull request
Aug 26, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#94051
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.