Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter_wkwebview] Implementation of PlatformWebViewCookieManager for WebKit #6240

Merged
auto-submit merged 6 commits into from
Aug 23, 2022
Merged

[webview_flutter_wkwebview] Implementation of PlatformWebViewCookieManager for WebKit #6240

auto-submit merged 6 commits into from
Aug 23, 2022

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Aug 12, 2022

Part of flutter/flutter#94051

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-ios labels Aug 12, 2022
@bparrishMines bparrishMines added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 12, 2022
stuartmorgan-g
stuartmorgan-g approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2022
@auto-submit auto-submit bot merged commit 3a5e6f3 into flutter:main Aug 23, 2022
@bparrishMines bparrishMines deleted the wkwebview_cookie_manager branch August 23, 2022 13:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2022
@engine-flutter-autoroll
3a5e6f3ac [webview_flutter_wkwebview] Implementation of PlatformWebVi…
e350d14 
…ewCookieManager for WebKit (flutter/plugins#6240)
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
@bparrishMines @moisefeelin
[webview_flutter_wkwebview] Implementation of PlatformWebViewCookieMa…
899ef53 
…nager for WebKit (flutter#6240)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@bparrishMines @mauricioluz
[webview_flutter_wkwebview] Implementation of PlatformWebViewCookieMa…
1fa4be2 
…nager for WebKit (flutter#6240)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: webview_flutter Edits files for a webview_flutter plugin platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bparrishMines @stuartmorgan-g