This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[quick_actions] backfill some unit tests for FLTQuickActionsPlugin class
#6206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
force-pushed
the
quick_actions_add_unit_tests
branch
from
7ce0588 to
6877996
Compare
hellohuanlin
force-pushed
the
quick_actions_add_unit_tests
branch
from
6877996 to
28aa87d
Compare
hellohuanlin
commented
Aug 4, 2022
|
|
||
| /// The type of the shortcut item selected when launching the app. | ||
| /// API exposed for unit tests. | ||
| @property(nonatomic, strong, nullable) NSString *launchingShortcutType; |
Contributor
Author
There was a problem hiding this comment.
In next PR I will refactor FLTQuickActionsPlugin into smaller components, so that we won't have to expose these private APIs, as discussed in the proposal here.
hellohuanlin
changed the title
FLTQuickActionsPlugin class
cyanglaz
reviewed
Aug 4, 2022
packages/quick_actions/quick_actions_ios/example/ios/RunnerTests/FLTQuickActionsPluginTests.m
Show resolved
Hide resolved
packages/quick_actions/quick_actions_ios/example/ios/RunnerTests/FLTQuickActionsPluginTests.m
Outdated
Show resolved
Hide resolved
packages/quick_actions/quick_actions_ios/example/ios/RunnerTests/FLTQuickActionsPluginTests.m
Show resolved
Hide resolved
packages/quick_actions/quick_actions_ios/example/ios/RunnerTests/FLTQuickActionsPluginTests.m
Show resolved
Hide resolved
jmagman
reviewed
Aug 4, 2022
packages/quick_actions/quick_actions_ios/example/ios/RunnerTests/FLTQuickActionsPluginTests.m
Show resolved
Hide resolved
packages/quick_actions/quick_actions_ios/example/ios/RunnerTests/FLTQuickActionsPluginTests.m
Show resolved
Hide resolved
jmagman
approved these changes
Aug 5, 2022
hellohuanlin
force-pushed
the
quick_actions_add_unit_tests
branch
from
7388ad4 to
928caaa
Compare
hellohuanlin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2022
yutaaraki-toydium
pushed a commit
to yutaaraki-toydium/plugins
that referenced
this pull request
Aug 12, 2022
moisefeelin
pushed a commit
to feelinproject/plugins
that referenced
this pull request
Aug 26, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that a few private APIs are not covered yet. We could expose them using test headers, however, a better approach is a pre-migration refactor to move these private APIs to a separate component (as discussed in the proposal here),
Since we want this quick_actions migration to be a "demo" migration, we will go with the refactor approach and add more tests in the next PR, which should remove the need of exposing private APIs.
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#108750
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.