This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Move Cirrus task logs to flutter-infra-staging project #6180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
reviewed
Aug 3, 2022
| 'Device model(s) to test. See https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run for more info'); | ||
| argParser.addOption('results-bucket', | ||
| defaultsTo: 'gs://flutter_firebase_testlab'); | ||
| defaultsTo: 'gs://flutter_firebase_testlab_staging'); |
Contributor
There was a problem hiding this comment.
This is the bucket only, I assume there is another CL on recipes to change the GCP project used by gcloud firebaselab ... command. Am I right?
Contributor
Author
There was a problem hiding this comment.
Yes, my other PR in the recipes repo is changing the project to flutter-infra-staging. It is changing the recipe for the firebase commands.
godofredoc
approved these changes
Aug 3, 2022
Contributor
godofredoc
left a comment
godofredoc
left a comment
There was a problem hiding this comment.
@stuartmorgan FYI the logs location is being changed. Please let us know if you get any problems accessing the logs.
Contributor
|
I'll keep an eye on it; thanks for the heads up! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2022
yutaaraki-toydium
pushed a commit
to yutaaraki-toydium/plugins
that referenced
this pull request
Aug 12, 2022
* Changed cirrus logging to flutter-firebase-testlab-staging * Fix test data
moisefeelin
pushed a commit
to feelinproject/plugins
that referenced
this pull request
Aug 26, 2022
* Changed cirrus logging to flutter-firebase-testlab-staging * Fix test data
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* Changed cirrus logging to flutter-firebase-testlab-staging * Fix test data
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logs for cirrus tests will be moved to the GCP flutter-infra-staging project to prepare for security hardening.
Issue
This addresses work for a flutter infra OKR.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.