This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[file_selector] Enable ArgumentErrors for type groups #6126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picks up the breaking changes to each implementation that includes throwing `ArgumentError`s for unsupported type groups, and updates the documentation accordingly. Fixes flutter/flutter#107469
ditman
approved these changes
Jul 20, 2022
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
This is an excellent change. Thanks!
ditman
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2022
yutaaraki-toydium
pushed a commit
to yutaaraki-toydium/plugins
that referenced
this pull request
Aug 12, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up the breaking changes to each implementation that includes
throwing
ArgumentErrors for unsupported type groups, and updates thedocumentation accordingly. This is a breaking change for the app-facing
package.
Fixes flutter/flutter#107469
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).