This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter_wkwebvew] Fix UIScrollView regression for inset behavior #6104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: webview_flutter
cyanglaz
approved these changes
Jul 14, 2022
Comment on lines
+433
to
+442
| FWFInstanceManager *instanceManager = [[FWFInstanceManager alloc] init]; | ||
| FWFWebViewHostApiImpl *hostAPI = [[FWFWebViewHostApiImpl alloc] | ||
| initWithBinaryMessenger:OCMProtocolMock(@protocol(FlutterBinaryMessenger)) | ||
| instanceManager:instanceManager]; | ||
|
|
||
| [instanceManager addDartCreatedInstance:[[WKWebViewConfiguration alloc] init] withIdentifier:0]; | ||
|
|
||
| FlutterError *error; | ||
| [hostAPI createWithIdentifier:@1 configurationIdentifier:@0 error:&error]; | ||
| FWFWebView *webView = (FWFWebView *)[instanceManager instanceForIdentifier:1]; |
Contributor
There was a problem hiding this comment.
nits: Should all of these wrapped inside if (@available(iOS 13, *)) so they don't run if below iOS 13?
Contributor
Author
There was a problem hiding this comment.
Good point. I updated the methods with their repspective API_AVAILABLE(ios(11.0))
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Ah, I'll use that next time. I didn't know there were XCT methods for it. I would have assumed XCode would have recommend this solution.
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 15, 2022
yutaaraki-toydium
pushed a commit
to yutaaraki-toydium/plugins
that referenced
this pull request
Aug 12, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like these lines were missed when creating the new implementation:
plugins/packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FlutterWebView.m
Lines 128 to 133 in bdec9ba
This PR adds them to
FWFWebViewand adds the tests from the old implementation to verify these settings.Fixes: flutter/flutter#107639
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.