[tools] Remove single-example RepositoryPackage method #5600
Conversation
Eliminates the remaining uses of the deprecated method for returning the example for a package that assumed there must be only one example, migrating the remaining uses to support multi-example. Fixes one unit test that was accidentally testing the wrong failure case due to a copy/paste mistake, noticed while updating tests for this change.
|
I forgot this was still here, and noticed it while fixing |
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Great improvement for the tooling. I wonder how a multi-example package will score in pub (it'll probably get some points deducted because example/lib/main.dart doesn't exist?)
It's a documented convention, so in theory they should support it: https://dart.dev/tools/pub/package-layout#examples I checked |
stuartmorgan-g
added
the
waiting for tree to go green
3 participants
Eliminates the remaining uses of the deprecated method for returning the
example for a package that assumed there must be only one example,
migrating the remaining uses to support multi-example.
Fixes one unit test that was accidentally testing the wrong failure case
due to a copy/paste mistake, noticed while updating tests for this
change.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).