-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[ci] Shorten dependabot prefixes to comply with config spec. #5474
Conversation
|
Attempted to shorten the names by removing "redundant" bits, like: |
blasten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it kinds of defeats the purpose. maybe we just don't have prefixes?
The label should be added to the PR, but if the idea was to search through history using the prefix, then that seems unfeasible.
|
Dependabot seems to also be adding We can create an issue on |
It'll become the commit message, so having shortened forms is still better than nothing. We actually shouldn't have the |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, the [] puts several of them just over.
This LGTM then.
|
|
|
I'm going to land this on red to re-open |
Capturing from Discord for posterity: I didn't realize the package path would be in the title. I'm now on board with not having prefixes. |
|
Just a heads up. It seems this change made dependabot to create hundreds PRs that @ditman just closes. This caused thousands of macos tasks to be created on Cirrus in a very short period of time which is causing some longer then usual processing times. |
|
@fkorotkov yes, apologies for the spam. When I realized this would be abusing Cirrus, it was probably too late (x_x) |
|
No worries. Just wanted to let you know that there is some unintentional slowness. An interesting use case. Haven't seen that many PRs from dependbot at once plus our physical Mac Mini infra is not elastic like everything else in the cloud. 😪 |
…#5474) (Landing on red to reopen tree)
Dependabot prefixes have a maximum of 15 chars (docs).
This PR shortens the prefixes introduced here: #5440 so the dependabot action doesn't fail.
(Needs to land on red)
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.