Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@ditman
Copy link
Member

@ditman ditman commented May 3, 2022

Dependabot prefixes have a maximum of 15 chars (docs).

This PR shortens the prefixes introduced here: #5440 so the dependabot action doesn't fail.

(Needs to land on red)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested review from blasten and stuartmorgan-g May 3, 2022 01:32
@ditman
Copy link
Member Author

ditman commented May 3, 2022

Attempted to shorten the names by removing "redundant" bits, like: google, flutter and android (platform-android should be added by the PR labeler, right?). When that wasn't enough, I shortened some words, attempting to leave the name of the plugin still a sub-string of the longer name (for the future verification script(?))

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it kinds of defeats the purpose. maybe we just don't have prefixes?

The label should be added to the PR, but if the idea was to search through history using the prefix, then that seems unfeasible.

@ditman
Copy link
Member Author

ditman commented May 3, 2022

Dependabot seems to also be adding : after the specified prefix, and that's going to look weird in our repo as well. Issue.

We can create an issue on dependabot asking them to respect whatever we pass as a prefix, but they might have their limitations on why not to do it :/ For now, I think this is going to look less weird without the prefixes, even the shortened ones (so dependabot commits will look similar to the autoroller's)

@stuartmorgan-g
Copy link
Contributor

it kinds of defeats the purpose. maybe we just don't have prefixes?

The label should be added to the PR, but if the idea was to search through history using the prefix, then that seems unfeasible.

It'll become the commit message, so having shortened forms is still better than nothing.

We actually shouldn't have the _android suffixes anyway, since the convention we use is to put the conceptual plugin name rather than the package name. Where we can fit the whole plugin name, I'd like to keep that. Most of them should be <15

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, the [] puts several of them just over.

This LGTM then.

@ditman
Copy link
Member Author

ditman commented May 3, 2022

[google_maps] should fit, for example, let me minimize the shortening.

@ditman
Copy link
Member Author

ditman commented May 3, 2022

I'm going to land this on red to re-open main. This can be easily revisited to tweak the names and/or create an issue for dependabot.

@ditman ditman merged commit 580de32 into flutter:main May 3, 2022
@ditman ditman deleted the fix-dependabot-prefixes branch May 3, 2022 02:05
@ditman
Copy link
Member Author

ditman commented May 3, 2022

@stuartmorgan-g
Copy link
Contributor

It'll become the commit message, so having shortened forms is still better than nothing.

Capturing from Discord for posterity: I didn't realize the package path would be in the title. I'm now on board with not having prefixes.

@fkorotkov
Copy link
Contributor

Just a heads up. It seems this change made dependabot to create hundreds PRs that @ditman just closes.

This caused thousands of macos tasks to be created on Cirrus in a very short period of time which is causing some longer then usual processing times.

@ditman
Copy link
Member Author

ditman commented May 3, 2022

@fkorotkov yes, apologies for the spam. When I realized this would be abusing Cirrus, it was probably too late (x_x)

@fkorotkov
Copy link
Contributor

No worries. Just wanted to let you know that there is some unintentional slowness. An interesting use case. Haven't seen that many PRs from dependbot at once plus our physical Mac Mini infra is not elastic like everything else in the cloud. 😪

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants