Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

Addresses flutter/flutter#102801 for this repository.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
Copy link
Contributor Author

This should do it, but obviously I can't test without landing it and seeing what happens...

Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@stuartmorgan-g
Copy link
Contributor Author

Landing; we get a slightly confusing "no tests" result in the UI (along with all the tests), so maybe there's a better way to do this, but it at least prevents us running all the tests twice.

@stuartmorgan-g stuartmorgan-g merged commit b247855 into main Apr 29, 2022
@stuartmorgan-g stuartmorgan-g deleted the cirrus-skip-master branch April 29, 2022 18:05
@stuartmorgan-g
Copy link
Contributor Author

@godofredoc I forget, is there a documented timeframe in the master->main migration plan for how long to keep master? Presumably at some point we can just remove it entirely and the problem goes away.

@ditman
Copy link
Member

ditman commented Apr 29, 2022

flutter/packages has worked correctly with this change (and the extra "neutral" build output for the master branch)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants