Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

remove unnecessary imports #5410

Merged
fluttergithubbot merged 13 commits into from
May 2, 2022
Merged

remove unnecessary imports #5410

fluttergithubbot merged 13 commits into from
May 2, 2022

Conversation

@G1Joshi
Copy link
Contributor

@G1Joshi G1Joshi commented Apr 27, 2022 •
edited by stuartmorgan-g
Loading

Removed all unnecessary imports because all of the used elements are also provided by the other imports.

  • This will increase overall pub points.

No version change:
No functional change for plugin clients

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@G1Joshi G1Joshi requested a review from bparrishMines as a code owner April 27, 2022 03:53
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Apr 27, 2022

Thanks for the contribution! I've updated the PR description to exempt it from the version change requirement, and marked that it's test-exempt (being entirely no-op removal), but this will need ## NEXT changelog entries as described in the linked documentation.

@G1Joshi
Copy link
Contributor Author

G1Joshi commented Apr 27, 2022 •
edited
Loading

I have updated the CHANGELOG!

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Apr 28, 2022 •
edited
Loading

I just noticed that we still have:

   # TODO(https://github.com/flutter/flutter/issues/74381):
   # Clean up existing unnecessary imports, and remove line to ignore.
   unnecessary_import: ignore

in our analysis_options.yaml. This PR should remove that, since presumably it's fixing all the remaining violations (and if it doesn't currently, it should). That way we are ensuring that this won't regress in the future.

stuartmorgan-g
stuartmorgan-g reviewed Apr 28, 2022
View reviewed changes
@G1Joshi
Copy link
Contributor Author

G1Joshi commented Apr 28, 2022

#74381

hellohuanlin
hellohuanlin approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning this up

@G1Joshi G1Joshi requested a review from gaaclarke as a code owner April 28, 2022 18:27
ditman
ditman approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, I can't believe we can remove dart:async and flutter/foundation.dart from so many places! Good riddance!

stuartmorgan-g
stuartmorgan-g suggested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning all this up!

I removed the "No CHANGELOG change:" from the PR description; that override was not correct. As I said above, this will need a changelog change for each affected package. (Currently it's only in some of them.)

@G1Joshi G1Joshi requested a review from stuartmorgan-g April 29, 2022 17:12
@G1Joshi
Copy link
Contributor Author

G1Joshi commented Apr 30, 2022

I have made all the required changes.

stuartmorgan-g
stuartmorgan-g approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this cleanup!

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 2, 2022
@fluttergithubbot fluttergithubbot merged commit bbcb88d into flutter:main May 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2022
@engine-flutter-autoroll
bbcb88d3b remove unnecessary imports (flutter/plugins#5410)
fb59b95
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@G1Joshi @mauricioluz
remove unnecessary imports (flutter#5410)
4878026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@blasten blasten Awaiting requested review from blasten

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

4 more reviewers

@asashour asashour asashour left review comments

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@ditman ditman ditman approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p: camera p: file_selector p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: ios_platform_images p: local_auth p: path_provider p: quick_actions p: shared_preferences p: url_launcher p: video_player p: webview_flutter Edits files for a webview_flutter plugin platform-android platform-ios platform-linux platform-macos platform-web platform-windows waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@G1Joshi @stuartmorgan-g @ditman @asashour @hellohuanlin @fluttergithubbot