Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in_web] Add plugin_name to init call. #5242

Merged
fluttergithubbot merged 4 commits into from
Apr 13, 2022
Merged

[google_sign_in_web] Add plugin_name to init call. #5242

fluttergithubbot merged 4 commits into from
Apr 13, 2022

Conversation

@ditman
Copy link
Member

@ditman ditman commented Apr 12, 2022 •
edited
Loading

This change ensures that a plugin_name attribute with a known value is passed to the init call of the current Web implementation of Google Sign In JS SDK.

This allows "new applications to continue using the plugin after April 30th, 2022".

Mitigates: flutter/flutter#88084
See also: flutter/flutter#101004

//FYI @brdaugherty @kevmoo

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from stuartmorgan-g April 12, 2022 23:40
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Apr 13, 2022

How does this work? Is this a special value that's whitelisted on the server side?

@ditman
Copy link
Member Author

ditman commented Apr 13, 2022 •
edited
Loading

How does this work? Is this a special value that's whitelisted on the server side?

@stuartmorgan The presence of the key with any (unique-ish) value is an escape hatch to let the backend know that we need more time to do the actual migration to the new API.

If not present, new apps Client IDs created from April 20th won't be allowed to use the old SDK.

((Apologies for the internal link, but) please do check cl/439406676 for the documentation CL, it'll be published soon)

stuartmorgan-g
stuartmorgan-g approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

(Is it normal for us to be editing files in src/generated, or is this a special case?)

@ditman
Copy link
Member Author

ditman commented Apr 13, 2022 •
edited
Loading

(Is it normal for us to be editing files in src/generated, or is this a special case?)

@stuartmorgan Fair question. These files used to be generated when the plugin got started, but the generator hasn't kept up with the changes we needed to do. They probably should be moved out of generated since they've been manually maintained for the last couple of years.

Created this issue to track cleanup: flutter/flutter#101855

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 13, 2022
@fluttergithubbot fluttergithubbot merged commit af665ae into flutter:main Apr 13, 2022
@ditman ditman deleted the add-gsi-plugin-name branch April 14, 2022 00:41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
af665aee6 [google_sign_in_web] Add plugin_name to init call. (flu…
b3536a0 
…tter/plugins#5242)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@ditman @mauricioluz
[google_sign_in_web] Add plugin_name to init call. (flutter#5242)
2b7746e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p: google_sign_in platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ditman @stuartmorgan-g @fluttergithubbot