[local_auth] Update app facing package to use default method channel implementation in new platform interface package. #5195
Conversation
…tation in platform interface.
| enum BiometricType { face, fingerprint, iris } | ||
|
|
||
| const MethodChannel _channel = MethodChannel('plugins.flutter.io/local_auth'); | ||
| export 'package:local_auth_platform_interface/types/biometric_type.dart'; |
There was a problem hiding this comment.
We should remember to make the version update a breaking change when re-publishing this plugin, since this is where we're introducing the new enum values. (Which doesn't necessarily have to be a breaking change, but I think that's the best way to do it.)
There was a problem hiding this comment.
Sounds like a plan, will update this in #4701.
…/federation_native_precursor
…/federation_native_precursor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM once this is updated to published version of #5196
BeMacized
added
the
waiting for tree to go green
|
@stuartmorgan I'd mark this to be merged, but |
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
For some reason when In this case, |
BeMacized
added
the
waiting for tree to go green
…d channel implementation in new platform interface package. (flutter/plugins#5195)
…d channel implementation in new platform interface package. (flutter/plugins#5195)
…d channel implementation in new platform interface package. (flutter/plugins#5195)
…d channel implementation in new platform interface package. (flutter/plugins#5195)
…implementation in new platform interface package. (flutter#5195)
3 participants
This PR updates the app facing package to switch over to the default method channel implementation provided by the new platform interface package.
This is a precursor PR to #4699, #4700 and #4701, and is required to fix the integation tests running properly with those PRs.
Relevant issues:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.NEXT. This will be updated by [local_auth] Refactor package to make use of new platform interface and native implementations #4701. Should this already be done here instead?CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.