Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] fix warning #5131

Merged
fluttergithubbot merged 6 commits into from
Apr 29, 2022
Merged

[webview_flutter] fix warning #5131

fluttergithubbot merged 6 commits into from
Apr 29, 2022

Conversation

@rocketnik
Copy link
Contributor

@rocketnik rocketnik commented Mar 31, 2022 •
edited
Loading

When the webview_flutter plugin compiles for iOS, it produces the following warning two times:
"'requiresuseractionformediaplayback' is deprecated: first deprecated in ios 10.0"

This PR disables those warnings in the same way, that other warnings of the same kind are already disabled.
The code leading to the warnings is fine, because it is there to explicitly handle the deprecations. Now that they are handled, the warnings can be ignored.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 31, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Mar 31, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-ios labels Mar 31, 2022
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Apr 5, 2022

Thanks for the submission!

In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored it to the PR description), which need to be addressed before it moves forward with review.

I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

@stuartmorgan-g stuartmorgan-g removed the request for review from bparrishMines April 5, 2022 18:15
@stuartmorgan-g stuartmorgan-g marked this pull request as draft April 5, 2022 18:15
@rocketnik rocketnik changed the title fix warning [webview_flutter] fix warning Apr 25, 2022
@rocketnik rocketnik marked this pull request as ready for review April 25, 2022 20:46
@rocketnik rocketnik requested a review from cyanglaz as a code owner April 25, 2022 20:46
cyanglaz
cyanglaz suggested changes Apr 29, 2022
View reviewed changes
packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md Outdated

## 2.7.3

* Removes two compile time warnings
Copy link
Contributor

@cyanglaz cyanglaz Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Period in the end of the sentence. Also, please make the CHANGELOG include more details. (What warnings are removed)

Copy link
Contributor Author

@rocketnik rocketnik Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@rocketnik
Copy link
Contributor Author

rocketnik commented Apr 29, 2022

Thank you for the review, I made appropriate fixes.

@rocketnik rocketnik requested a review from cyanglaz April 29, 2022 17:53
cyanglaz
cyanglaz approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stuartmorgan-g
stuartmorgan-g approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Hixie
Copy link
Contributor

Hixie commented Apr 29, 2022

test-exempt: fixes warnings

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 29, 2022
@fluttergithubbot fluttergithubbot merged commit 7a741bf into flutter:main Apr 29, 2022
@rocketnik
Copy link
Contributor Author

rocketnik commented Apr 29, 2022

Thank you for the great reviews!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2022
@engine-flutter-autoroll
7a741bf0b [webview_flutter] fix warning (flutter/plugins#5131)
60c2ac0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2022
@engine-flutter-autoroll
7a741bf0b [webview_flutter] fix warning (flutter/plugins#5131)
73512d8
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@rocketnik @mauricioluz
[webview_flutter] fix warning (flutter#5131)
fce60cb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests p: webview_flutter Edits files for a webview_flutter plugin platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rocketnik @stuartmorgan-g @Hixie @cyanglaz @fluttergithubbot