Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

Adds file_selector_macos as an endorsed implementation, and enables
the example to build for macOS.

The code in example/ is the template-generated code, unchanged except
for adding the license.

Part of flutter/flutter#70221

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g stuartmorgan-g requested a review from cbracken March 4, 2022 17:44
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g stuartmorgan-g changed the title Endorse file selector macos [file_selector] Endorse macOS Mar 4, 2022
@stuartmorgan-g
Copy link
Contributor Author

@cbracken I did the flutter create --platforms=macos . as its own commit, so reviewing the commits (and just skipping that one) rather than the full diff should be easier.

@christopherfujino
Copy link

test-exempt: is a test

by adding the new platform new CI testing is enabled

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 4, 2022
@fluttergithubbot fluttergithubbot merged commit f32730d into flutter:main Mar 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2022
sensuikan1973 added a commit to sensuikan1973/pedax that referenced this pull request May 8, 2022
* use path_provider_macos on only test

* remove redundant dev deps

* file_selector_macos and file_selector_windows has been endorsed. See: flutter/plugins#5001 and flutter/plugins#4696

* meta package is contained in Dart SDK

* analyzer

* add meta on dev_deps

* rever meta package change
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests p: file_selector platform-macos waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants