Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

migrate from ui.hash* to Object.hash* #4994

Merged
fluttergithubbot merged 3 commits into from
Apr 7, 2022
Merged

migrate from ui.hash* to Object.hash* #4994

fluttergithubbot merged 3 commits into from
Apr 7, 2022

Conversation

@werainkhatri
Copy link
Member

@werainkhatri werainkhatri commented Mar 4, 2022 •
edited
Loading

flutter/flutter#85431

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@werainkhatri werainkhatri changed the title migrate from ui.hash* Object.hash* migrate from ui.hash* to Object.hash* Mar 4, 2022
@werainkhatri werainkhatri mentioned this pull request Mar 4, 2022
Merged
13 tasks
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Mar 7, 2022

Have you verified that all of the plugins you are changing set the correct minimum Flutter version to use this code?

@werainkhatri
Copy link
Member Author

werainkhatri commented Mar 14, 2022

I hadn't (sorry bout that). Object.hash* appeared in dart 2.14 (flutter 2.5.0). So should i update the min flutter sdk in those few plugins (below) from 2.0.0 to 2.5.0 or 2.8.0?

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Mar 14, 2022

If it was added in 2.5, then you should update them to 2.5.0.

@werainkhatri
Copy link
Member Author

werainkhatri commented Mar 14, 2022

done, PTAL

stuartmorgan-g
stuartmorgan-g approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the changelog nits addressed.

@werainkhatri werainkhatri force-pushed the migrate-hash branch 2 times, most recently from 893c2b3 to 5f2c243 Compare March 30, 2022 13:05
@werainkhatri
Copy link
Member Author

werainkhatri commented Mar 30, 2022

i have made the changes and rebased with main. could you help me with the failing check? thanks :)

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Apr 6, 2022

What's the failing check? It looks green to me.

@stuartmorgan-g stuartmorgan-g mentioned this pull request Apr 6, 2022
Merged
10 tasks
@werainkhatri
Copy link
Member Author

werainkhatri commented Apr 7, 2022 •
edited
Loading

The submit-queue check.

If it's not needed, this can be merged. Thanks!

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Apr 7, 2022

submit-queue is the live state of the tree; it's not related to the PR. You can add the waiting for tree to go green label regardless of the state of that test.

This will need to be rebased before it can be landed though.

@werainkhatri werainkhatri added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 7, 2022
@fluttergithubbot fluttergithubbot merged commit 9e87433 into flutter:main Apr 7, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 7, 2022
@engine-flutter-autoroll
9e874339e migrate from ui.hash* to Object.hash* (flutter/plugins#4994)
6974b99
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2022
@engine-flutter-autoroll
9e874339e migrate from ui.hash* to Object.hash* (flutter/plugins#4994)
0e63568
@ditman
Copy link
Member

ditman commented Apr 11, 2022

This was a good merge, congrats on getting it landed! :D

@werainkhatri werainkhatri deleted the migrate-hash branch April 16, 2022 16:10
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@werainkhatri @mauricioluz
migrate from ui.hash* to Object.hash* (flutter#4994)
908eb24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p: camera p: google_maps_flutter p: google_sign_in p: in_app_purchase p: ios_platform_images p: webview_flutter Edits files for a webview_flutter plugin platform-android platform-ios platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@werainkhatri @stuartmorgan-g @ditman @fluttergithubbot