Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] update maps sdk for Android #4984

Merged
fluttergithubbot merged 9 commits into from
Apr 27, 2022
Merged

[google_maps_flutter] update maps sdk for Android #4984

fluttergithubbot merged 9 commits into from
Apr 27, 2022

Conversation

@maheshj01
Copy link
Member

@maheshj01 maheshj01 commented Mar 3, 2022 •
edited
Loading

This PR updates the google maps sdk to version 18.0.2
source: https://developers.google.com/maps/documentation/android-sdk/releases

Fixes: flutter/flutter#92651

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 3, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Mar 3, 2022

test-exempt: rolling dependency

stuartmorgan-g
stuartmorgan-g suggested changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently failing tests.

@maheshj01 maheshj01 requested a review from stuartmorgan-g March 7, 2022 17:54
@maheshj01
Copy link
Member Author

maheshj01 commented Mar 18, 2022

@stuartmorgan Could you please re-review this?

@stuartmorgan-g stuartmorgan-g requested a review from blasten March 25, 2022 19:11
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Mar 25, 2022

@blasten please review or delegate, since this is Android-specific.

blasten
blasten approved these changes Apr 14, 2022
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stuartmorgan-g
stuartmorgan-g approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CHANGELOG is fixed.

@maheshj01 maheshj01 requested a review from GaryQian as a code owner April 27, 2022 14:19
@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 27, 2022
@fluttergithubbot fluttergithubbot merged commit d78cc8e into flutter:main Apr 27, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
d78cc8eaa [google_maps_flutter] update maps sdk for Android (flutter/…
0da562e 
…plugins#4984)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
d78cc8eaa [google_maps_flutter] update maps sdk for Android (flutter/…
3d03178 
…plugins#4984)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@maheshj01 @mauricioluz
[google_maps_flutter] update maps sdk for Android (flutter#4984)
b630e6f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GaryQian GaryQian Awaiting requested review from GaryQian

2 more reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests p: google_maps_flutter platform-android waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[google_maps_flutter] [Proposal] Update to Google maps 18 SDK

5 participants

@maheshj01 @Hixie @stuartmorgan-g @blasten @fluttergithubbot