Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@CaseyHillers
Copy link

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Feb 28, 2022
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux plugin_tools_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite format has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite dart_unit_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite dart_unit_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite linux-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite linux-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite linux-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite linux-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite darwin-lint_podspecs has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite macos-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite macos-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite macos-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite macos-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Feb 28, 2022
@CaseyHillers CaseyHillers added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 1, 2022
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux plugin_tools_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite format has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite dart_unit_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite dart_unit_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite linux-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite linux-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite linux-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite linux-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite darwin-lint_podspecs has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite macos-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite macos-build_all_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite macos-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite macos-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 1, 2022
@CaseyHillers CaseyHillers merged commit 6826dff into main Mar 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants