Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Update iOS to new analysis options #4920

Merged
fluttergithubbot merged 4 commits into from
Feb 25, 2022
Merged

[in_app_purchase] Update iOS to new analysis options #4920

fluttergithubbot merged 4 commits into from
Feb 25, 2022

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Feb 24, 2022

Switches from legacy analysis options to current analysis options,
fixing all analysis issues it exposed.

Part of flutter/flutter#76229

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft February 24, 2022 15:57
@stuartmorgan-g stuartmorgan-g marked this pull request as ready for review February 24, 2022 16:47
mvanbeusekom
mvanbeusekom approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (minus the conflict with the script/configs/custom_analysis.yaml)

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Feb 25, 2022
@fluttergithubbot fluttergithubbot merged commit 045e651 into flutter:main Feb 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
045e65199 [in_app_purchase] Update iOS to new analysis options (flutt…
f0dfc65 
…er/plugins#4920)
@stuartmorgan-g stuartmorgan-g deleted the analysis-iap-storekit branch April 19, 2022 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p: in_app_purchase platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuartmorgan-g @mvanbeusekom @fluttergithubbot