This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Added new option allowBackgroundPlayback #4908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/video_player/video_player_platform_interface/CHANGELOG.md
IlyaMax
changed the title
IlyaMax
changed the title
IlyaMax
changed the title
stuartmorgan-g
suggested changes
Feb 25, 2022
| required bool isObserving, | ||
| }) { | ||
| final wasPlayingBeforePause = controller.value.isPlaying; | ||
| WidgetsBinding.instance! |
Contributor
There was a problem hiding this comment.
You'll need to add _ambiguate to this file and call it on these lines to fix the analyzer issue on master.
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22 | ||
| version: 2.2.18 | ||
| version: 2.3.0 | ||
|
|
Contributor
There was a problem hiding this comment.
You need to update the video_player_platform_interface minimum version to require the version that added the new option. As written someone's project could pass through package resolution with a version that wouldn't compile.
ghost
mentioned this pull request
Contributor
Author
|
@EconomicEgret yes, thanks, I'm not interested in this pr for now, hope you finish it. |
Contributor
Author
|
I close this as you can continue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4324 reopened this pr
Duplicated description from above issue
This PR introduces a new option to VideoPlayerOptions, which enables user to decide on whether user wants to keep playing video in the background or not.
This does NOT add functionality of video playback with controls. It could be achieved with audio_service package for instance.
Related issues
Fixes flutter/flutter#63836
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.