Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Feb 23, 2022

The fix is self-explainable ;) Just two lines of doc.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot changed the base branch from master to main February 23, 2022 03:49
@flutter-dashboard
Copy link

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

@github-actions github-actions bot added the p: webview_flutter Edits files for a webview_flutter plugin label Feb 23, 2022
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Feb 23, 2022

Do I really need to create an issue for this? If so I will do it...

@stuartmorgan-g
Copy link
Contributor

This doesn't require an issue, but does require the other items on the checklist.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft February 23, 2022 20:25
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Feb 24, 2022

Done

@stuartmorgan-g
Copy link
Contributor

When you've resolved the issues with the publishable check, please mark this as ready for review.

@fzyzcjy fzyzcjy marked this pull request as ready for review February 24, 2022 02:09
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added last mile waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. labels Feb 24, 2022
@fluttergithubbot fluttergithubbot merged commit f3f8e72 into flutter:main Feb 24, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p: webview_flutter Edits files for a webview_flutter plugin waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants