This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider] Remove use of deprecated pedantic package #4764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not sure if this change should be part of a release or not. The only user-visible change is in the examples, but that doesn't seem significant. |
stuartmorgan-g
suggested changes
Feb 8, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
We don't use lints in this repository. These lines can all just be straight up removed; pedantic was there from when we used the legacy repo analysis options, and I just forgot to remove the dependency when removing the legacy options.
Contributor
Since you'll just be removing a cruft line from dev dependencies, you can use the "No version change" and "No CHANGELOG change" overrides in the PR description. (You'll need to update it before you push so "publishable" passes.) |
robert-ancell
force-pushed
the
path-provider-lints
branch
from
f5dbd74 to
2c0f4cf
Compare
robert-ancell
changed the title
This package is deprectated and this repository doesn't use the replacement (lints).
robert-ancell
force-pushed
the
path-provider-lints
branch
from
2c0f4cf to
34a316f
Compare
stuartmorgan-g
added
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of deprecated pedantic package
No version change: Removing cruft
No CHANGELOG change: Removing cruft
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.