This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera_platform_interface] Fix asynchronous exceptions handling of the initializeCamera method
#4660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@bparrishMines Could you do the initial review here? |
stuartmorgan-g
approved these changes
Jan 26, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
I made a small fix to the changelog entry to match our styleguide; LGTM with that.
stuartmorgan-g
added
last mile
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
…ing of the `initializeCamera` method (flutter/plugins#4660)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details here flutter/flutter#96405. The problem is that we are not using
awaitforinvokeMapMethodin theMethodChannelCamera.initializeCameramethod:plugins/packages/camera/camera_platform_interface/lib/src/method_channel/method_channel_camera.dart
Lines 118 to 132 in 9aca084
The solution to is to asynchronously catch
PlatformExceptionand passing it to_completer.Fix flutter/flutter#96405
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.