This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Add a backgroundColor option to the Android webview #4569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: webview_flutter
stuartmorgan-g
suggested changes
Dec 3, 2021
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Minor nits, and this needs the auto-formatter run so CI passes.
@bparrishMines or @mvanbeusekom for secondary review.
| WebViewController controller, BuildContext context) async { | ||
| final String contentBase64 = | ||
| base64Encode(const Utf8Encoder().convert(kTransparentBackgroundPage)); | ||
| await controller.loadUrl('data:text/html;base64,$contentBase64'); |
Contributor
There was a problem hiding this comment.
Nit: As with the iOS review, this can use loadHtmlString now.
packages/webview_flutter/webview_flutter_android/test/android_webview.pigeon.dart
Show resolved
Hide resolved
Contributor
Author
|
I made the changes. I also hard code the |
Closed
stuartmorgan-g
approved these changes
Dec 4, 2021
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM!
I made a dummy PR at #4579 to run the new test in CI just to make sure it's working there.
...d/app/src/androidTest/java/io/flutter/plugins/webviewflutterexample/BackgroundColorTest.java
Show resolved
Hide resolved
mvanbeusekom
approved these changes
Dec 4, 2021
Contributor
mvanbeusekom
left a comment
mvanbeusekom
left a comment
There was a problem hiding this comment.
LGTM with one small nit
Contributor
|
I've filed an issue tracking the FTL problem, and temporarily disabled the integration test. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
…flutter#4569) This PR add an option to set the background color of the Android webview. Part of: flutter#3431 Part of: flutter/flutter#29300
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
…flutter#4569) This PR add an option to set the background color of the Android webview. Part of: flutter#3431 Part of: flutter/flutter#29300
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add an option to set the background color of the Android webview.
Original PR :
#3431
It fixes this issue :
flutter/flutter#29300
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.