-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[url_launcher] Publish fully federated version #4536
[url_launcher] Publish fully federated version #4536
Conversation
Restores the app-facing package to a publishable state now that _android and _ios implementation packages are published. Part of flutter/flutter#68498
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although tree is red showing some dependency resolution errors.
Sorry was a bit too fast, see comment below.
mvanbeusekom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a closer look, packages url_launcher_ios version 2.0.16 and url_launcher_android version 2.0.16 don't exists. On pub.dev they are reported as version 6.0.13.
|
🤦🏻♂️ Sorry, I didn't realize I hadn't ever checked the test results on this PR. |
mvanbeusekom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three times is the charm, LGTM ;)
Restores the app-facing package to a publishable state now that _android and _ios implementation packages are published. Part of flutter/flutter#68498
Restores the app-facing package to a publishable state now that _android and _ios implementation packages are published. Part of flutter/flutter#68498
Restores the app-facing package to a publishable state now that _android
and _ios implementation packages are published.
Part of flutter/flutter#68498
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).