Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

Restores the app-facing package to a publishable state now that _android
and _ios implementation packages are published.

Part of flutter/flutter#68498

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Restores the app-facing package to a publishable state now that _android
and _ios implementation packages are published.

Part of flutter/flutter#68498
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although tree is red showing some dependency resolution errors.

Sorry was a bit too fast, see comment below.

Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a closer look, packages url_launcher_ios version 2.0.16 and url_launcher_android version 2.0.16 don't exists. On pub.dev they are reported as version 6.0.13.

@stuartmorgan-g
Copy link
Contributor Author

🤦🏻‍♂️ Sorry, I didn't realize I hadn't ever checked the test results on this PR.

Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three times is the charm, LGTM ;)

@stuartmorgan-g stuartmorgan-g merged commit a456f63 into flutter:master Nov 29, 2021
@stuartmorgan-g stuartmorgan-g deleted the url-launcher-publish-federated branch November 29, 2021 00:03
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 29, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
Restores the app-facing package to a publishable state now that _android
and _ios implementation packages are published.

Part of flutter/flutter#68498
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Restores the app-facing package to a publishable state now that _android
and _ios implementation packages are published.

Part of flutter/flutter#68498
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants