This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[flutter_plugin_tools] Build gtest unit tests #4492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds Windows and Linux unit tests before running them in `native-test`, in order to match the behavior of other platforms and significantly improve the UX of running the command locally while changing tests. Fixes flutter/flutter#89303
stuartmorgan-g
commented
Nov 9, 2021
| "${FLUTTER_ROOT}/packages/flutter_tools/bin/tool_backend.sh" | ||
| linux-x64 ${CMAKE_BUILD_TYPE} | ||
| ${FLUTTER_TARGET_PLATFORM} ${CMAKE_BUILD_TYPE} | ||
| VERBATIM |
Contributor
Author
There was a problem hiding this comment.
These two lines are auto-migrations by flutter that have just never been checked in.
| UrlLauncherPluginRegisterWithRegistrar( | ||
| registry->GetRegistrarForPlugin("UrlLauncherPlugin")); | ||
| UrlLauncherWindowsRegisterWithRegistrar( | ||
| registry->GetRegistrarForPlugin("UrlLauncherWindows")); |
Contributor
Author
There was a problem hiding this comment.
Apparently I forgot to check in the updated generated registrant when I restructured the plugin for unit testability.
gaaclarke
approved these changes
Nov 12, 2021
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
LGTM with just a few minor observations.
stuartmorgan-g
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds Windows and Linux unit tests before running them in
native-test, in order to match the behavior of other platforms andsignificantly improve the UX of running the command locally while
changing tests.
Fixes flutter/flutter#89303
Pre-launch Checklist
dart format.)[shared_preferences]///).