[ci] use background script #4349
Conversation
There is a special instruction in Cirrus for that https://cirrus-ci.org/guide/writing-tasks/#background-script-instruction Might be related to flutter/flutter#90078
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM! Let's try this and see if it helps the repo recover!
| - dart pub get | ||
| - dart lib/web_driver_installer.dart chromedriver --install-only | ||
| - ./chromedriver/chromedriver --port=4444 & | ||
| - ./chromedriver/chromedriver --port=4444 |
There was a problem hiding this comment.
We probably want this to be a separate script step that is background, and the rest to stay as-is.
There was a problem hiding this comment.
install_script:
- git clone https://github.com/flutter/web_installers.git
- cd web_installers/packages/web_drivers/
- dart pub get
- dart lib/web_driver_installer.dart chromedriver --install-only
install_background_script:
- ./chromedriver/chromedriver --port=4444
?
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
This is probably going to fail:
dart lib/web_driver_installer.dart chromedriver --install-only
Error when reading 'lib/web_driver_installer.dart': No such file or directory.
Does this need to cd at the beginning of the install_background_script (similarly to how we cd web_installers/packages/web_drivers/ at the beginning of install_script?)
|
Does seems like it's working now: https://cirrus-ci.com/task/6037670892666880?logs=chromedriver#L10 Waiting for all the checks to pass. |
|
I'll merge on red when the rest of the tests pass. Thanks @fkorotkov for the super fast fix! |
|
@ditman it might failed to stream in real-time and will try to recover once the whole tasks finishes... Let's wait. |
|
Do we know why the old version suddenly broke? |
|
@stuartmorgan yeah, seems this is the reason flutter/flutter#90078 (comment) |
Since this can't possible affect any tasks other than the one in changed, and those are green, I'm going to land now to green the tree. |
Uses the background script annotation, since & no longer works.
Uses the background script annotation, since & no longer works.
3 participants
There is a special instruction in Cirrus for that https://cirrus-ci.org/guide/writing-tasks/#background-script-instruction
Might be related to flutter/flutter#90078
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.