Update url_launcher README #4

szakarias · 2017-04-21T09:31:08Z

First draft. A short guide/one-liner which we discussed could replace what is written in the Usage section.

mit-mit

Some smaller comments

mit-mit · 2017-04-21T11:13:41Z

packages/url-launcher/README.md

+## Usage

-Try out the plugin by running the project in the example/ folder.
+Get this plugin as described [here] (https://www.dartlang.org/tools/pub/get-started).


I'd replace this line with:

To use this plugin, add url_launcher as a [dependency in your pubspec.yaml file](https://flutter.io/platform-plugins/).

mit-mit · 2017-04-21T11:15:00Z

packages/url-launcher/README.md

+
+## Supported URL schemes
+
+The supported URL schemes depend on the underlying platform and installed system apps.


I don't think only system apps can handle URLs, so suggest just saying 'installed apps'.

mit-mit · 2017-04-21T11:16:36Z

packages/url-launcher/README.md

+```
+
+## Supported URL schemes
+


Maybe start with: 'The launch method takes a string argument containing a URL. This URL can formatted using a number of different URL schemes.'

mit-mit · 2017-04-21T11:17:20Z

packages/url-launcher/README.md

+More details can be found here for [iOS](https://developer.apple.com/library/content/featuredarticles/iPhoneURLScheme_Reference/Introduction/Introduction.html) or [Android](https://developer.android.com/guide/components/intents-common.html)
+
+
+## More info


I think we can omit this section as the top usage line I suggested has the same link in it.

PR review changes

# This is the 1st commit message: review fixes # This is the commit message #2: Update packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m review fix Co-Authored-By: cyanglaz <[email protected]> # This is the commit message #3: Update packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m Co-Authored-By: cyanglaz <[email protected]> # This is the commit message flutter#4: Update packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m review fix Co-Authored-By: cyanglaz <[email protected]> # This is the commit message flutter#5: Update packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m Co-Authored-By: cyanglaz <[email protected]> # This is the commit message flutter#6: Update packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m Co-Authored-By: cyanglaz <[email protected]>

Throw an error if speed is unsupported on iOS + better documentation

FAILURE: Build failed with an exception. * Where: Build file 'C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\build.gradle' line: 22 * What went wrong: A problem occurred evaluating root project 'shared_preferences_macos'. > Failed to apply plugin [id 'com.android.library'] > Minimum supported Gradle version is 5.4.1. Current version is 5.1.1. If using the gradle wrapper, try editing the distributionUrl in C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\gradle\wrapper\gradle-wrapper.properties to gradle-5.4.1-all.zip * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 1s [ +1 ms] Running Gradle task 'assembleAarRelease'... (completed in 2,0s) [ ] FAILURE: Build failed with an exception. * Where: Build file 'C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\build.gradle' line: 22 * What went wrong: A problem occurred evaluating root project 'shared_preferences_macos'. > Failed to apply plugin [id 'com.android.library'] > Minimum supported Gradle version is 5.4.1. Current version is 5.1.1. If using the gradle wrapper, try editing the distributionUrl in C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\gradle\wrapper\gradle-wrapper.properties to gradle-5.4.1-all.zip * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 1s [ +5 ms] "flutter apk" took 179.497ms. The plugin shared_preferences_macos could not be built due to the issue above. #0 throwToolExit (package:flutter_tools/src/base/common.dart:28:3) flutter#1 buildPluginsAsAar (package:flutter_tools/src/android/gradle.dart:726:7) flutter#2 _asyncErrorWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:80:45) #3 _rootRunBinary (dart:async/zone.dart:1146:38) flutter#4 _CustomZone.runBinary (dart:async/zone.dart:1039:19) flutter#5 _FutureListener.handleError (dart:async/future_impl.dart:153:20) flutter#6 Future._propagateToListeners.handleError (dart:async/future_impl.dart:692:47) flutter#7 Future._propagateToListeners (dart:async/future_impl.dart:713:24) flutter#8 Future._completeError (dart:async/future_impl.dart:532:5) flutter#9 _AsyncAwaitCompleter.completeError (dart:async-patch/async_patch.dart:38:15) flutter#10 buildGradleAar (package:flutter_tools/src/android/gradle.dart) flutter#11 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64) flutter#12 _rootRunUnary (dart:async/zone.dart:1134:38) flutter#13 _CustomZone.runUnary (dart:async/zone.dart:1031:19) flutter#14 _FutureListener.handleValue (dart:async/future_impl.dart:139:18) flutter#15 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45) flutter#16 Future._propagateToListeners (dart:async/future_impl.dart:709:32) #17 Future._completeWithValue (dart:async/future_impl.dart:524:5) flutter#18 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:32:15) flutter#19 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:290:13) flutter#20 _DefaultProcessUtils.run (package:flutter_tools/src/base/process.dart) flutter#21 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64) flutter#22 _rootRunUnary (dart:async/zone.dart:1134:38) flutter#23 _CustomZone.runUnary (dart:async/zone.dart:1031:19) flutter#24 _FutureListener.handleValue (dart:async/future_impl.dart:139:18) flutter#25 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45) flutter#26 Future._propagateToListeners (dart:async/future_impl.dart:709:32) flutter#27 Future._completeWithValue (dart:async/future_impl.dart:524:5) flutter#28 Future.wait.<anonymous closure> (dart:async/future.dart:400:22) flutter#29 _rootRunUnary (dart:async/zone.dart:1134:38) flutter#30 _CustomZone.runUnary (dart:async/zone.dart:1031:19) flutter#31 _FutureListener.handleValue (dart:async/future_impl.dart:139:18) flutter#32 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45) flutter#33 Future._propagateToListeners (dart:async/future_impl.dart:709:32) flutter#34 Future._completeWithValue (dart:async/future_impl.dart:524:5) flutter#35 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:554:7) flutter#36 _rootRun (dart:async/zone.dart:1126:13) flutter#37 _CustomZone.run (dart:async/zone.dart:1023:19) flutter#38 _CustomZone.runGuarded (dart:async/zone.dart:925:7) flutter#39 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23) flutter#40 _microtaskLoop (dart:async/schedule_microtask.dart:43:21) flutter#41 _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5) flutter#42 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13) flutter#43 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:175:5)

Add horizontal commit from flutter/plugins repo

Update master

…ffset-error Fix NRE when calling setExposureOffset

szakarias added 2 commits April 21, 2017 11:13

update README

2077c2d

remove empty lines

5637b25

szakarias requested a review from mit-mit April 21, 2017 09:31

mit-mit reviewed Apr 21, 2017

View reviewed changes

Address comments

f77111f

mit-mit approved these changes Apr 21, 2017

View reviewed changes

szakarias merged commit 71cc3d9 into flutter:master Apr 21, 2017

jonasbark pushed a commit to jonasbark/plugins that referenced this pull request Apr 19, 2018

Merge pull request flutter#4 from holykou/master

9dfbb34

PR review changes

This was referenced Dec 6, 2019

Fix:avoid calling setState() when mounted is false. #2360

Closed

[Sensors] Fix:avoid calling setState() when mounted is false. #2361

Closed

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019

Merge pull request flutter#4 from recastrodiaz/speed

6882ce4

Throw an error if speed is unsupported on iOS + better documentation

srburton mentioned this pull request Feb 21, 2020

[FIX] - Gradle #2546

Closed

13 tasks

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020

Merge pull request flutter#4 from bparrishMines/horizontal

f1e60a5

Add horizontal commit from flutter/plugins repo

sumitrvi mentioned this pull request Apr 15, 2020

Fixes error handling in firebase_auth on Android and iOS #775

Merged

sanekyy pushed a commit to optimist-dev/plugins that referenced this pull request Nov 1, 2020

Merge pull request flutter#4 from flutter/master

e2613e0

Update master

muhammednazil mentioned this pull request Dec 20, 2020

Int testing #3355

Closed

PiN73 mentioned this pull request Mar 17, 2021

Document how to use pigeon and update to the latest version. #3281

Merged

nt4f04uNd pushed a commit to nt4f04uNd/plugins that referenced this pull request Mar 23, 2021

Merge pull request flutter#4 from bottlepay/android-rework-exposure-o…

4a4c082

…ffset-error Fix NRE when calling setExposureOffset

PeterOmbodi added a commit to PeterOmbodi/plugins that referenced this pull request May 13, 2021

fix flutter#4

ffcd6b7

jorgesarabia mentioned this pull request Jul 28, 2022

Bugfix/update package wenzhiming/flutter-plugins#5

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update url_launcher README #4

Update url_launcher README #4

Uh oh!

szakarias commented Apr 21, 2017

Uh oh!

mit-mit left a comment

Uh oh!

mit-mit Apr 21, 2017

Uh oh!

mit-mit Apr 21, 2017

Uh oh!

mit-mit Apr 21, 2017

Uh oh!

mit-mit Apr 21, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		## Supported URL schemes

		The supported URL schemes depend on the underlying platform and installed system apps.

		More details can be found here for [iOS](https://developer.apple.com/library/content/featuredarticles/iPhoneURLScheme_Reference/Introduction/Introduction.html) or [Android](https://developer.android.com/guide/components/intents-common.html)


		## More info

Update url_launcher README #4

Update url_launcher README #4

Uh oh!

Conversation

szakarias commented Apr 21, 2017

Uh oh!

mit-mit left a comment

Choose a reason for hiding this comment

Uh oh!

mit-mit Apr 21, 2017

Choose a reason for hiding this comment

Uh oh!

mit-mit Apr 21, 2017

Choose a reason for hiding this comment

Uh oh!

mit-mit Apr 21, 2017

Choose a reason for hiding this comment

Uh oh!

mit-mit Apr 21, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants