Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Reword README #3784

Merged
fluttergithubbot merged 3 commits into from
Apr 5, 2021
Merged

[google_maps_flutter] Reword README #3784

fluttergithubbot merged 3 commits into from
Apr 5, 2021

Conversation

@kalkih
Copy link
Contributor

@kalkih kalkih commented Apr 2, 2021 •
edited
Loading

Improves wording of the Getting Started chapter in the google maps flutter readme.

Fixes flutter/flutter#79633

I assume no changelog entry is needed for this change?

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@kalkih kalkih requested a review from cyanglaz as a code owner April 2, 2021 11:01
@google-cla google-cla bot added the cla: yes label Apr 2, 2021
@cyanglaz
Copy link
Contributor

cyanglaz commented Apr 2, 2021

@kwalrath It looks like an English wording issue. The change makes sense to me. Could you also take a look please :)

@kalkih It will require a CHANGELOG and pubspec update if we want to show this change in pub.dev.
Or you can make it a dev version so we won't publish a new release just for a README change.
See: #3768 (comment)

@kalkih
Copy link
Contributor Author

kalkih commented Apr 5, 2021

Thanks @cyanglaz
I added a changelog entry and bumped the -dev version, should I perhaps not have bumped the version number and just put it under 2.0.3-dev, please let me know and I'll change it if that's the case. 🙂

kwalrath
kwalrath approved these changes Apr 5, 2021
View reviewed changes
Copy link

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, but it'd be even better to put the link on meaningful words (instead of "here": https://developers.google.com/style/highlights#tone-and-content) and maybe to make them not be in the bulleted list (since they don't seem parallel with the other items in the list).

@cyanglaz cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 5, 2021
@fluttergithubbot fluttergithubbot merged commit 00ec3cd into flutter:master Apr 5, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2021
@engine-flutter-autoroll
00ec3cd [google_maps_flutter] Reword README (flutter/plugins#3784)
e8aa6fa
stuartmorgan-g
stuartmorgan-g reviewed Apr 5, 2021
View reviewed changes
packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md
@@ -1,3 +1,7 @@
## 2.0.4-dev
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Apr 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should either have been 2.0.3-dev.1 if we didn't want to publish, or 2.0.3 if we did (which I think is the case; generally we want to publish README improvements). We've now skipped 2.0.3.

We should update the version bump script to prevent this.

@stuartmorgan-g stuartmorgan-g mentioned this pull request Apr 5, 2021
Closed
@cyanglaz cyanglaz mentioned this pull request Apr 6, 2021
Merged
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Apr 6, 2021
@engine-flutter-autoroll
00ec3cd [google_maps_flutter] Reword README (flutter/plugins#3784) (#…
181b4db 
…79820)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@kalkih @fotiDim
[google_maps_flutter] Reword README (flutter#3784)
424825e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

2 more reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g left review comments

@kwalrath kwalrath kwalrath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: google_maps_flutter waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[google_maps_flutter] Wording in README

5 participants

@kalkih @cyanglaz @stuartmorgan-g @kwalrath @fluttergithubbot