This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Update build-all test for null-safe template #3773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flutter master now creates NNBD code when running 'flutter create', so the generated pubspec for build_all needs to use a compatible SDK version. This updates from 2.0.0 to 2.12.0. Also includes a test for this, which involved setting up tests for the file, and doing some refactoring to make the command testable. As a result, this fixes flutter/flutter#61049 (although more test backfill is needed).
stuartmorgan-g
commented
Mar 30, 2021
| for version in "${BUILD_MODES[@]}"; do | ||
| echo "Building $version..." | ||
| (cd $REPO_DIR/all_plugins && flutter build $@ --$version) | ||
| (cd $REPO_DIR/all_plugins && flutter build $@ --$version --no-sound-null-safety) |
Contributor
Author
There was a problem hiding this comment.
@ditman I had to add this because of web Maps, so once this lands if you can update your NNBD PR to remove it, it should work.
Member
There was a problem hiding this comment.
Yep, I'll update mine once this lands. (For cross-linking purposes, this is what's supposed to be updated: #3726)
Contributor
Author
|
Landing on red since all PRs are broken on this. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 31, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Flutter master now creates NNBD code when running 'flutter create', so the generated pubspec for build_all needs to use a compatible SDK version. This updates from 2.0.0 to 2.12.0. Also includes a test for this, which involved setting up tests for the file, and doing some refactoring to make the command testable. As a result, this fixes flutter/flutter#61049 (although more test backfill is needed).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter master now creates NNBD code when running 'flutter create', so
the generated pubspec for build_all needs to use a compatible SDK
version. This updates from 2.0.0 to 2.12.0.
Also includes a test for this, which involved setting up tests for the
file, and doing some refactoring to make the command testable. As a
result, this fixes flutter/flutter#61049
(although more test backfill is needed).
Pre-launch Checklist
[shared_preferences]///).