[google_maps_flutter] Fix NNBD migration mistake in example #3768
Conversation
The TileOverlay portion of the example app incorrectly constructed a Set<TileOverlay?> and then attempted to cast it to a Set<TileOverlay>, rather than making a set of non-nullable types as required by the API. Fixes flutter/flutter#79242
|
No test for this change since it looks like this integration test is one of the ones that uses the APIs directly rather than driving the example app. |
| description: A Flutter plugin for integrating Google Maps in iOS and Android applications. | ||
| homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter/google_maps_flutter | ||
| version: 2.0.1 | ||
| version: 2.0.2 |
There was a problem hiding this comment.
Probably not necessary? Updating the version has no harm either.
There was a problem hiding this comment.
I thought more of the example was visible on pub.dev than it is.
I think it's worth mentioning in CHANGELOG, so I'll leave it. (Something I think we should consider is a way to add CHANGELOG lines for cases where it's not worth actually publishing yet. E.g., allow for "" as a version as long as the version in pubspec hasn't changed.)
There was a problem hiding this comment.
Dart people do -dev releases for these cases, until they need to publish for real, and then they collapse everything into a next version with multiple changelog entries.
There was a problem hiding this comment.
I like it; saves us needing any new tooling. We'll adopt that and see if we need to revisit.
3 participants
The TileOverlay portion of the example app incorrectly constructed a
Set<TileOverlay?> and then attempted to cast it to a Set,
rather than making a set of non-nullable types as required by the API.
Fixes flutter/flutter#79242
Pre-launch Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.