Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[wifi_info_flutter] Edit sample wifi_info_flutter plugin #3271

Merged
bparrishMines merged 3 commits into from
Dec 15, 2020
Merged

[wifi_info_flutter] Edit sample wifi_info_flutter plugin #3271

bparrishMines merged 3 commits into from
Dec 15, 2020

Conversation

@febryardiansyah
Copy link
Contributor

@febryardiansyah febryardiansyah commented Nov 17, 2020 •
edited
Loading

Description

I've edited the sample of wifi_info_flutter plugin that not suitable with the plugin.
Thanks.

Related Issues

  • Sample on readme is not suitable with the plugin

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@febryardiansyah
Edit sample wifi_info_flutter plugin
8a50ecd 
Hello, i've edited the sample of wifi_info_flutter plugin that not suitable with the plugin.
Thanks.
@google-cla
Copy link

google-cla bot commented Nov 17, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 17, 2020
@febryardiansyah
Copy link
Contributor Author

febryardiansyah commented Nov 17, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 17, 2020
@febryardiansyah febryardiansyah changed the title Edit sample wifi_info_flutter plugin [wifi_info_flutter] Edit sample wifi_info_flutter plugin Nov 17, 2020
bparrishMines
bparrishMines approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution! I'll do a version bump and merge it.

@bparrishMines
Copy link
Contributor

bparrishMines commented Dec 15, 2020

Merging since the tree is currently green

@bparrishMines bparrishMines merged commit bad9fd1 into flutter:master Dec 15, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
23d4af9 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
b8713c8 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
5d1d4c5 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
09b1f40 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
c359ecd 
…tter/plugins#3271)
NickalasB added a commit to NickalasB/plugins that referenced this pull request Dec 17, 2020
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
84fe69a 
* master:
  [camera] Ios support documentation  (flutter#3335)
  Remove custom null safety analysis_options files (flutter#3339)
  [webview_flutter] Added 'allowsInlineMediaPlayback' property (flutter#3334)
  [camera_platform_interface] Add torch definition to the FlashModes enum  (flutter#3326)
  [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flutter#3271)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java
#	packages/webview_flutter/lib/platform_interface.dart
#	packages/webview_flutter/pubspec.yaml
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
5000d13 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
1f3cbc3 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
e31b419 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
ed13c57 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
682ef15 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
e1c7812 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
85701dd 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
354e26b 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
28d0e29 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 20, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
1ee0378 
…tter/plugins#3271)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 29, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 29, 2020
@engine-flutter-autoroll
bad9fd1 [wifi_info_flutter] Edit sample wifi_info_flutter plugin (flu…
48c0c36 
…tter/plugins#3271)
@stuartmorgan-g stuartmorgan-g mentioned this pull request Feb 4, 2021
Closed
13 tasks
amantoux pushed a commit to amantoux/plugins that referenced this pull request Feb 8, 2021
@febryardiansyah @amantoux
[wifi_info_flutter] Edit sample wifi_info_flutter plugin (flutter#3271)
76da627
adsonpleal pushed a commit to nubank/plugins that referenced this pull request Feb 26, 2021
@febryardiansyah @adsonpleal
[wifi_info_flutter] Edit sample wifi_info_flutter plugin (flutter#3271)
8d6bcd7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bparrishMines bparrishMines bparrishMines approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@febryardiansyah @bparrishMines